It's not a crapshoot, as I do when hiring any professional I verified his qualifications before hiring him.As far as the lawyers go, what you just said is that it is basically a crapshoot if you are going to get a good trust and if the lawyer knows anything about NFA items.
How do you know the lawyer you have mentioned didn't google NFA trust info, find out the information on the net already out there and say he knows a lot about it and would gladly charge you $2500 to write one up?
Lets not make this personal. The bottom line is you get what you pay for. A homemade trust is clearly sufficient to get the ATF to approve your forms. It MAY be sufficient for your personal estate planning needs. It MAY also contribute to the ATF tightening the rules in the future regarding trusts and corporations.
Arguing that your trust is somehow better or cheaper or whatever than mine is silly.